C++/Programming thread

[Paddy]

For a project, i’m creating ConnectFour (4 in a row i think its called in the states) and i’ve kind of hit a wall, i’ve got my main menu, my grid built up using arrays, but i’m not acctually sure how to acctually get the user to play the game.

For example how do i update the grid when the user takes there turn?

Also, i’d like to clear the menu away from the screen once the user has made their choice.

Code:

#include “stdafx.h”
#include

using namespace std;
int menu();
int grid();
int highscore();
int exit();

int main()
{
menu();

}

int menu()
{

int user_option;

cout<<"											Welcome to ConnectFour! This is the main menu! Enter the option of your choice to continue!";
cout<<endl;
cout<<"1. Start new game!";
cout<<endl;
cout<<"2. View high scores";
cout<<endl;
cout<<"3. Exit game and return to desktop";
cout<<endl;
cout<<endl;
cout<<"Please enter your choice: ";

cin>>user_option;

if (user_option == 1)
	{
		grid();
	}

if (user_option == 2)
{
	highscore();
}

if (user_option == 3)
{
	exit();
}

return 0;

}

int grid()

{
int i;
char columnarray1[7]={'"','"','"','"','"','"','"'};
char columnarray2[7]={'"','"','"','"','"','"','"'};
char columnarray3[7]={'"','"','"','"','"','"','"'};
char columnarray4[7]={'"','"','"','"','"','"','"'};
char columnarray5[7]={'"','"','"','"','"','"','"'};
char columnarray6[7]={'"','"','"','"','"','"','"'};
char columnarray7[7]={'"','"','"','"','"','"','"'};

cout<<"           ConnectFour"<<endl;

for(i=0; i<7; i++)
{
	cout<<"|  "<<columnarray1[i]<<"   |  "<<columnarray2[i]<<"   |  "<<columnarray3[i]<<"   |  "<<columnarray4[i]<<"   |  "<<columnarray5[i]<<"   |  "<<columnarray6[i]<<"   |  "<<columnarray7[i]<<"   | \n -------------------------------------------------"<<endl;
}
cout<<"|  1   |  2   |  3   |  4   |  5   |  6   |  7   |"<<endl<<endl<<"Player 1 = X  ||  Player 2 = O  ||  Empty Slot = \""<<endl;

return 0;

}

int highscore()
{
return 0;
}

int exit()
{
return 0;
}

high score is empty because i haven’t gotten round to doing that yet, and exit is a function as far as i’m aware, but not sure if i’ve implamented it right,

If anyone has any adive or tips on how to do any of that, it’d be great.

: )

[Maxey]

Reverse-engineer the real thing.

[Paddy]

Haha, i know the rules to connect4, just not sure how to program it hah

[bur]

I’ve actually been programming connect four too for college, in java.

You have to ask the player for an x-coordinate (the column of choice) and then insert the player’s symbol (probably X or O) into the array.
Then reprint the array.

[pfannkuchen_gesicht]

why do you use 7 1D Arrays instead of one 7x7 Array(char grid[7][7])?

[Zageron]

@pfannkuchen_gesicht

why do you use 7 1D Arrays instead of one 7x7 Array(char grid[7][7])?

That’s what I was going to ask. x.x

[FeisEater]

Well I basically just copyed your code and added some features on it. It has everything a connect four game should have except it doesn’t detect wins and it doesn’t have computer AI. Do you want me to instruct you on how to progress with your coding or just paste on this thread what I made?

[bur]

@pfannkuchen_gesicht

why do you use 7 1D Arrays instead of one 7x7 Array(char grid[7][7])?

yeah that’s pretty impractical

[Paddy]

@FeisEater

Well I basically just copyed your code and added some features on it. It has everything a connect four game should have except it doesn’t detect wins and it doesn’t have computer AI. Do you want me to instruct you on how to progress with your coding or just paste on this thread what I made?

Cheers man! Paste it in, i learn better through reading/doing things than just theory, if i don’t understand any of the changes could i ask you?

Thanks man!

[FeisEater]

Well here it is. I’m still a bit of a newbie in programming plus it was a bit rushed, so some parts of code might be crudly written. But it works!

#include “stdafx.h”
#include

using namespace std;

void menu();
void refresh( bool gameover ); //Used to be grid, renamed it to more appropriate
void highscore(); //How is highscore going to work in connect four?
void exit();
void turn(); //Calculates a pebble dropping down to empty slot
int grid[7][6]; //Holds each players pebbles in 2d grid
int whichturn; //Remembers which turn it is
void checkwin( int lastturn ); //Checks if any player won
void playerwins( int player ); //Performs actions when someone does win

void main()
{
menu();

}

void menu()
{

int user_option;

cout<<" Welcome to ConnectFour! This is the main menu! Enter the option of your choice to continue!";
cout<<endl;
cout<<“1. Start new game!”;
cout<<endl;
cout<<“2. View high scores”;
cout<<endl;
cout<<“3. Exit game and return to desktop”;
cout<<endl;
cout<<endl;
cout<<"Please enter your choice: ";

//This fuction shall now perform actions needed to set up a new game.
for ( int i=0; i<8; i++ )
{
for ( int j=0; j<7; j++)
{
grid[i][j]=0;
}
}
//All grids emptied
whichturn = 1; //Player 1 always starts first
cin>>user_option;

if (user_option == 1)
{
refresh(false);
}

if (user_option == 2)
{
highscore();
}

if (user_option == 3)
{
exit();
}
}

void refresh( bool gameover )

{

int i;
/*char columnarray1[7]={’"’,’"’,’"’,’"’,’"’,’"’,’"’};
char columnarray2[7]={’"’,’"’,’"’,’"’,’"’,’"’,’"’};
char columnarray3[7]={’"’,’"’,’"’,’"’,’"’,’"’,’"’};
char columnarray4[7]={’"’,’"’,’"’,’"’,’"’,’"’,’"’};
char columnarray5[7]={’"’,’"’,’"’,’"’,’"’,’"’,’"’};
char columnarray6[7]={’"’,’"’,’"’,’"’,’"’,’"’,’"’};
char columnarray7[7]={’"’,’"’,’"’,’"’,’"’,’"’,’"’};
*/
cout<<" ConnectFour, player “<<whichturn<<” turn."<<endl;

for(i=1; i<7; i++)
{
cout<<"| “;
for ( int j=1; j<8; j++ )
{
if ( grid[j][i] == 0 ) cout<<’”’; //if grid[x][y] is zero, slot is empty
if ( grid[j][i] == 1 ) cout<<‘X’; //slot is owned by player1 pebble
if ( grid[j][i] == 2 ) cout<<‘O’; //slot is owned by player2 pebble
cout<<" | “;
//cout<<”| “<<columnarray1[i]<<” | “<<columnarray2[i]<<” | “<<columnarray3[i]<<” | “<<columnarray4[i]<<” | “<<columnarray5[i]<<” | “<<columnarray6[i]<<” | “<<columnarray7[i]<<” | \n -------------------------------------------------"<<endl;
}
cout<<endl;
}
if ( !gameover ) cout<<"| 1 | 2 | 3 | 4 | 5 | 6 | 7 |"<<endl<<endl<<"Player 1 = X || Player 2 = O || Empty Slot = “”<<endl;
if (gameover) cout<<endl;
if ( !gameover ) turn(); //gameover input added so you can draw the grid without prompting players to play
}

void turn()
{
int slot;
cin>>slot; //asks for a number from 1 to 7
if ( slot<1 || slot>7 )
{
cout<<“Invalid row. Try again!”<<endl;
turn();
return;
}
for ( int i=6; i>0; i-- )
{
if ( grid[slot][i] == 0 )
{
if ( whichturn == 1 )
{
grid[slot][i] = 1;
whichturn = 2;
checkwin(1);
return;
}
if ( whichturn == 2 )
{
grid[slot][i] = 2;
whichturn = 1;
checkwin(2);
return;
}
}
}
cout<<“This row is full. Try again!”<<endl;
turn();
}

void checkwin( int lastturn )
{
int hit=0;

//Checking four vertical slots
for ( int i=1; i<8; i++ )
{	
	for ( int j=1; j<7; j++ )
	{
		if ( grid[i][j]==lastturn )
		{
			hit++;
			if ( hit==4 )
			{
				playerwins(lastturn);
				return;
			}
		}
		else hit=0;
	}

hit=0;
}

//Checking four horizontal slots
for ( int i=1; i<7; i++ )
{	
	for ( int j=1; j<8; j++ )
	{
		if ( grid[j][i]==lastturn )
		{
			hit++;
			if ( hit==4 )
			{
				playerwins(lastturn);
				return;
			}
		}
		else hit=0;
	}
	hit=0;
}

//Checking four horizontal slots from top-left to bottom-right
for ( int i=3; i>0; i-- )
{	
	for ( int j=1; j<7; j++ )
	{
		if ( grid[j][i+(j-1)]==lastturn )
		{
			hit++;
			if ( hit==4 )
			{
				playerwins(lastturn);
				return;
			}
		}
		else hit=0;
		if ( i+(j-1) == 6 )	break;
	}
	hit=0;		
}
for ( int i=2; i<5; i++ )
{	
	for ( int j=1; j<7; j++ )
	{
		if ( grid[i+(j-1)][j]==lastturn )
		{
			hit++;
			if ( hit==4 )
			{
				playerwins(lastturn);
				return;
			}
		}
		else hit=0;
		if ( i+(j-1) == 7 )	break;
	}
	hit=0;		
}

//Checking four horizontal slots from bottom-left to top-right
for ( int i=4; i<7; i++ )
{	
	for ( int j=1; j<7; j++ )
	{
		if ( grid[j][i-(j-1)]==lastturn )
		{
			hit++;
			if ( hit==4 )
			{
				playerwins(lastturn);
				return;
			}
		}
		else hit=0;
		if ( i-(j-1) == 1 )	break;
	}
	hit=0;		
}
for ( int i=2; i<5; i++ )
{	
	for ( int j=6; j>0; j-- )
	{
		if ( grid[i-(j-6)][j]==lastturn )
		{
			hit++;
			if ( hit==4 )
			{
				playerwins(lastturn);
				return;
			}
		}
		else hit=0;
		if ( i-(j-6) == 7 )	break;
	}
	hit=0;		
}

refresh(false);

}

void playerwins( int player ) //someone won!
{
refresh(true);
cout<<“I be damned! Player “<<player<<” won!”<<endl;
cout<<“Type any key then press enter to start again.”<<endl;
char decision;
cin>>decision;
main();
}

void highscore()
{
}

void exit()
{
}

I also added the a function that checks if someone “connected four” and won. I’m not sure I want to make an AI because I don’t really know the strategies of this game. Ask me if some portion of the code is confusing you.

Also does anyone know how can you clear the console screen in iostream?
EDIT: fixed some bugs

[Paddy]

Cool mate, it’ll be a day or two before i can test that out, today is friday, so i’ll be hungover tomorow haha.

The high score system was poorly worded by me, in nut shell, its gonna save the wins to a txt file, eg player 1 won 3 times, player 2 won once etc, not the best i know.

[wheybags]

I wish my programming course taught us C++ not java :<
Oh well, I’ll learn it myself, and we will do it in second year.

[P_PORTAL_RTAL]

my course learned me 1.5 years of java and 0.5 of c and 0.5 of c++ and 1 of C# and also asembly >.<

[SinfulEnd]

FiesEater:

I have found it looks slightly neater to write the endl on the same line as the output text, but thats just personal preference I suppose. I just wasn’t sure if you were aware that you can do that.

ex. Instead of:
cout<<" Welcome to ConnectFour! This is the main menu! Enter the option of your choice to continue!";
cout<<endl;

Try:
cout << “Welcome to ConnectFour! This is the main menu! Enter the option of your choice to continue!” << endl;

[FeisEater]

That was actually a line of code that P-Thunder left, if you look further into the code you can see that I put multiple things on the same line of cout.

[wheybags]

@P(PORTAL)RTAL

my course learned me 1.5 years of java and 0.5 of c and 0.5 of c++ and 1 of C# and also asembly >.<

Yeah, we do assembly too, but it’s kind of annoying that while the engineering students learn to program in C++, pure CS students learn fucking java.

[Sethis]

Array subscript out of range (well, more like access violation when it comes to c/cpp)
Also, stack overflow. Your code is bugged like hell.
Also, int main();
Also, make use of classes/structures (they’re pretty much the same thing in cpp)
Also, make use of function return values.
Also, do not write code that does nothing (exit(), highscore())

void turn(); //Calculates a pebble dropping down to empty slot

Wrong. It does more than just calculating.

[sersoft]

[JamesKane]

Spent 30 mins on this…quite fun

https://pastebin.com/f94J8DP0

Added basic AI which just selects a random position.

[MtzBraves]

Nevermind.